[ 
https://issues.apache.org/jira/browse/HDFS-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282417#comment-15282417
 ] 

Andrew Wang commented on HDFS-2173:
-----------------------------------

Caught up on the issue, sorry for the delay [~boky01] and thanks for working on 
this. The test change looks good (though we need to break the long line). 
{{writeAll}} is not quite right though, note that we can have >2 storages 
configured, and we only want to throw an exception if we fail to write to all 
of them. For each failed storage, we want to be reporting the error too.

> saveNamespace should not throw IOE when only one storage directory fails to 
> write VERSION file
> ----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2173
>                 URL: https://issues.apache.org/jira/browse/HDFS-2173
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Edit log branch (HDFS-1073), 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Andras Bokor
>         Attachments: HDFS-2173.01.patch
>
>
> This JIRA tracks a TODO in TestSaveNamespace. Currently, if, while writing 
> the VERSION files in the storage directories, one of the directories fails, 
> the entire operation throws IOE. This is unnecessary -- instead, just that 
> directory should be marked as failed.
> This is targeted to be fixed _after_ HDFS-1073 is merged to trunk, since it 
> does not ever dataloss, and would rarely occur in practice (the dir would 
> have to fail between writing the fsimage file and writing VERSION)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to