[
https://issues.apache.org/jira/browse/HDFS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010805#comment-13010805
]
Hadoop QA commented on HDFS-1774:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474509/HDFS-1774.patch
against trunk revision 1083958.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.server.datanode.TestTransferRbw
org.apache.hadoop.hdfs.TestDFSShell
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/282//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/282//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/282//console
This message is automatically generated.
> Optimization in org.apache.hadoop.hdfs.server.datanode.FSDataset class.
> -----------------------------------------------------------------------
>
> Key: HDFS-1774
> URL: https://issues.apache.org/jira/browse/HDFS-1774
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Attachments: HDFS-1774.patch
>
>
> Inner class FSDir constructor is doing duplicate iterations over the listed
> files in the passed directory. We can optimize this to single loop and also
> we can avoid isDirectory check which will perform some native invocations.
> Consider a case: one directory has only one child directory and 10000
> files.
> 1) First loop will get the number of children directories.
> 2) if (numChildren > 0) , This condition will satisfy and again it will
> iterate 10001 times and also will check isDirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
