[
https://issues.apache.org/jira/browse/HDFS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010848#comment-13010848
]
Tanping Wang commented on HDFS-1773:
------------------------------------
I run test-patch with my patch
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1
warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to
differ from the contents of the lib directories.
[exec]
[exec]
[exec]
[exec]
[exec]
======================================================================
[exec]
======================================================================
[exec] Finished build.
[exec]
======================================================================
[exec]
======================================================================
[exec]
[exec]
So I went ahead run another test-patch with a fake patch whose content is
empty. And I got the same result. I have also run $ant javadoc with and
without my patch and I got total of 31 javadoc warnings with out without my
patch.
I also run ant test. With and without my patch, I have seen the follow tests
failed on branch-20-security,
[junit] Test org.apache.hadoop.util.TestQueueProcessingStatistics FAILED
[junit] Test org.apache.hadoop.hdfsproxy.TestHdfsProxy FAILED
These two tests are not related with my patch.
> Remove a datanode from cluster if include list is not empty and this datanode
> is removed from both include and exclude lists
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1773
> URL: https://issues.apache.org/jira/browse/HDFS-1773
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.20.203.1
> Environment: branch-20-security
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Priority: Minor
> Fix For: 0.20.4
>
> Attachments: HDFS-1773-2.patch, HDFS-1773-3.patch, HDFS-1773.patch
>
>
> Our service engineering team who operates the clusters on a daily basis
> founds it is confusing that after a data node is decommissioned, there is no
> way to make the cluster forget about this data node and it always remains in
> the dead node list.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
