[
https://issues.apache.org/jira/browse/HDFS-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287977#comment-15287977
]
Mingliang Liu commented on HDFS-10415:
--------------------------------------
[~sjlee0], interesting question. I see code difference in
{{MyDistributedFileSystem}} between {{trunk}} and {{branch-2}}:
{code}
+ // Symlink resolution doesn't work with a mock, since it doesn't
+ // have a valid Configuration to resolve paths to the right FileSystem.
+ // Just call the DFSClient directly to register the delete
+ @Override
+ public boolean delete(Path f, final boolean recursive) throws IOException {
+ return dfs.delete(f.toUri().getPath(), recursive);
+ }
{code}
Please note that the {{dfs}} actually is a {{DFSClient}} object. In the
overridden {{delete()}} method, it calls the {{DFSClient#delete()}} directly,
bypassing all the stats related operations. That's said, we can even remove the
statement that creating {{statistics}} object in the
{{MyDistributedFileSystem}}.
I think we can follow the {{trunk}} code in test, in which way {{initialize()}}
and stats will be avoided elegantly as it's unrelated to the test. This will
address [[email protected]]'s concern.
> TestDistributedFileSystem#testDFSCloseOrdering() fails on branch-2
> ------------------------------------------------------------------
>
> Key: HDFS-10415
> URL: https://issues.apache.org/jira/browse/HDFS-10415
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.9.0
> Environment: jenkins
> Reporter: Sangjin Lee
> Assignee: Mingliang Liu
> Attachments: HDFS-10415-branch-2.000.patch
>
>
> {noformat}
> Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 51.096 sec
> <<< FAILURE! - in org.apache.hadoop.hdfs.TestDistributedFileSystem
> testDFSCloseOrdering(org.apache.hadoop.hdfs.TestDistributedFileSystem) Time
> elapsed: 0.045 sec <<< ERROR!
> java.lang.NullPointerException: null
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.delete(DistributedFileSystem.java:790)
> at
> org.apache.hadoop.fs.FileSystem.processDeleteOnExit(FileSystem.java:1417)
> at org.apache.hadoop.fs.FileSystem.close(FileSystem.java:2084)
> at
> org.apache.hadoop.hdfs.DistributedFileSystem.close(DistributedFileSystem.java:1187)
> at
> org.apache.hadoop.hdfs.TestDistributedFileSystem.testDFSCloseOrdering(TestDistributedFileSystem.java:217)
> {noformat}
> This is with Java 8 on Mac. It passes fine on trunk. I haven't tried other
> combinations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
