[
https://issues.apache.org/jira/browse/HDFS-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288804#comment-15288804
]
Hadoop QA commented on HDFS-10422:
----------------------------------
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
38s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 53s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
44s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 60m 19s
{color} | {color:green} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 79m 52s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12804615/HDFS-10422.001.patch |
| JIRA Issue | HDFS-10422 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 9eade854c2bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 8a9ecb7 |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/15480/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/15480/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> Do not throw AccessControlException for syntax errors of
> security.hdfs.unreadable.by.superuser
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-10422
> URL: https://issues.apache.org/jira/browse/HDFS-10422
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.7.2
> Reporter: Tianyin Xu
> Attachments: HDFS-10422.000.patch, HDFS-10422.001.patch
>
>
> The xattr {{security.hdfs.unreadable.by.superuser}} has certain syntax rules:
> "this xattr is also write-once, and cannot be removed once set. This xattr
> does not allow a value to be set."
> [https://hadoop.apache.org/docs/r2.7.2/hadoop-project-dist/hadoop-hdfs/ExtendedAttributes.html]
> Upon violation, the system should throw {{IllegalArgumentException}} to keep
> the consistent behaviour with the other xattrs such as
> {{raw.hdfs.crypto.encryption.zone}}.
> Currently, it always throws {{AccessControlException}} which is supposed to
> be something related to access control. The only case
> {{AccessControlException}} should be thrown is when the superuser tries to
> access the file, but *not* anything else.
> If the user set any value, it violates the syntax of the xattr (this xattr
> does not need values) which has nothing to do with access control:
> {code:title=XAttrPermissionFilter.java|borderStyle=solid}
> if (XAttrHelper.getPrefixedName(xAttr).
> equals(SECURITY_XATTR_UNREADABLE_BY_SUPERUSER)) {
> if (xAttr.getValue() != null) {
> throw new AccessControlException("Attempt to set a value for '" +
> SECURITY_XATTR_UNREADABLE_BY_SUPERUSER +
> "'. Values are not allowed for this xattr.");
> }
> return;
> }
> {code}
> \\
> Similarly, if the user wants to remove the xattr, it should throw
> {{IllegalArgumentException}} just like the encryption xattr in the following
> code. Basically I don't understand why the encryption xattr throws an
> {{IllegalArgumentException}} (via the {{checkArgument}} call) but the
> {{security.hdfs.unreadable.by.superuser}} xattr throws an
> {{AccessControlException}}. It's the same thing here: both of them cannot be
> removed...
> {code:title=FSDirXAttrOp.java|borderStyle=solid}
> Preconditions.checkArgument(
> !KEYID_XATTR.equalsIgnoreValue(filter),
> "The encryption zone xattr should never be deleted.");
> if (UNREADABLE_BY_SUPERUSER_XATTR.equalsIgnoreValue(filter)) {
> throw new AccessControlException("The xattr '" +
> SECURITY_XATTR_UNREADABLE_BY_SUPERUSER + "' can not be
> deleted.");
> }
> {code}
> This JIRA is related to HDFS-6891 (which introduced this xattr).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
