[
https://issues.apache.org/jira/browse/HDFS-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303547#comment-15303547
]
Chris Nauroth commented on HDFS-10430:
--------------------------------------
[~xiaobingo], this looks like a good change. Thank you for the patch. I have
just 2 minor comments:
# The {{checkAccessPermissions}} helper method seems unnecessary now that it's
just a pass-through to a single line of code. Do you think it makes sense to
move {{fs.access(path, mode);}} inline with {{testConcurrentAsyncAPI}} and
remove the extra method?
# Please remove the unused imports reported by Checkstyle.
> Reuse FileSystem#access in TestAsyncDFS
> ---------------------------------------
>
> Key: HDFS-10430
> URL: https://issues.apache.org/jira/browse/HDFS-10430
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10430-HDFS-9924.000.patch,
> HDFS-10430-HDFS-9924.001.patch
>
>
> In TestAsyncDFS, there are duplicate code to do access check. Here it tries
> to reuse FileSystem#access for the same goal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
