[
https://issues.apache.org/jira/browse/HDFS-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314384#comment-15314384
]
Akira AJISAKA commented on HDFS-10485:
--------------------------------------
I'm thinking numTransactionBatchedInSync should be AtomicLong or LongAdder
instead of long. We can use AtomicLong because we support JDK7 in branch-2.
> Fix findbugs warning in FSEditLog.java in branch-2
> --------------------------------------------------
>
> Key: HDFS-10485
> URL: https://issues.apache.org/jira/browse/HDFS-10485
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Akira AJISAKA
>
> Found 1 findbugs warning when creating a patch for branch-2 in HDFS-10341
> (https://builds.apache.org/job/PreCommit-HDFS-Build/15639/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html)
> {noformat}
> Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSEditLog.numTransactionsBatchedInSync;
> locked 50% of time
> Bug type IS2_INCONSISTENT_SYNC (click for details)
> In class org.apache.hadoop.hdfs.server.namenode.FSEditLog
> Field
> org.apache.hadoop.hdfs.server.namenode.FSEditLog.numTransactionsBatchedInSync
> Synchronized 50% of the time
> Unsynchronized access at FSEditLog.java:[line 676]
> Unsynchronized access at FSEditLog.java:[line 676]
> Synchronized access at FSEditLog.java:[line 1254]
> Synchronized access at FSEditLog.java:[line 716]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
