[
https://issues.apache.org/jira/browse/HDFS-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319151#comment-15319151
]
Xiaobing Zhou commented on HDFS-9943:
-------------------------------------
Patch v005 is posted to remove volatile for two parameters.
I checked dfs.namenode.replication.max-streams and
dfs.namenode.replication.max-streams-hard-limit are actually used somewhere
that hold namesystem.writeLock();, e.g. the stack trace
{code}
BlockManager#chooseSourceDatanodes
getMaxReplicationStreams
getReplicationStreamsHardLimit
BlockManager#scheduleReconstruction
BlockManager#computeReconstructionWorkForBlocks
// Step 1: categorize at-risk blocks into replication and EC tasks
namesystem.writeLock();
try {
synchronized (neededReconstruction) {
for (int priority = 0; priority < blocksToReconstruct
.size(); priority++) {
for (BlockInfo block : blocksToReconstruct.get(priority)) {
BlockReconstructionWork rw = scheduleReconstruction(block,
priority);
if (rw != null) {
reconWork.add(rw);
}
}
}
}
} finally {
namesystem.writeUnlock();
}
{code}
> Support reconfiguring namenode replication confs
> ------------------------------------------------
>
> Key: HDFS-9943
> URL: https://issues.apache.org/jira/browse/HDFS-9943
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9943-HDFS-9000.000.patch,
> HDFS-9943-HDFS-9000.001.patch, HDFS-9943-HDFS-9000.002.patch,
> HDFS-9943-HDFS-9000.003.patch, HDFS-9943-HDFS-9000.004.patch,
> HDFS-9943-HDFS-9000.005.patch
>
>
> The following confs should be re-configurable in runtime.
> - dfs.namenode.replication.work.multiplier.per.iteration
> - dfs.namenode.replication.interval
> - dfs.namenode.replication.max-streams
> - dfs.namenode.replication.max-streams-hard-limit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
