[ 
https://issues.apache.org/jira/browse/HDFS-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321320#comment-15321320
 ] 

Colin Patrick McCabe commented on HDFS-10506:
---------------------------------------------

>From 
>{{hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageReconstructor.java}}:
{code}
    private void processDirDiffEntry() throws IOException {
      LOG.debug("Processing dirDiffEntry");
...
        // TODO: add missing snapshotCopy field to XML
{code}

{code}
    private void processFileDiffEntry() throws IOException {
      LOG.debug("Processing fileDiffEntry");
...
        // TODO: missing snapshotCopy
        // TODO: missing blocks
        fileDiff.verifyNoRemainingKeys("fileDiff");
        bld.build().writeDelimitedTo(out);
      }
      expectTagEnd(SNAPSHOT_DIFF_SECTION_FILE_DIFF_ENTRY);
    }
{code}

> OIV's ReverseXML processor cannot reconstruct some snapshot details
> -------------------------------------------------------------------
>
>                 Key: HDFS-10506
>                 URL: https://issues.apache.org/jira/browse/HDFS-10506
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>
> OIV's ReverseXML processor cannot reconstruct some snapshot details.  
> Specifically, <fileDiff> should contain a <snapshotCopy> and <blocks> field, 
> but does not.  <dirDiff> should contain a <snapshotCopy> field.  OIV also 
> needs to be changed to emit these fields into the XML (they are currently 
> missing).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to