[
https://issues.apache.org/jira/browse/HDFS-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321426#comment-15321426
]
Bob Hansen commented on HDFS-10494:
-----------------------------------
This patch also includes all of HDFS-10491; we'll need to calculate the diffs
from there once it lands.
* Let's document the expected return values / errno state for the new
hdfs_ext.h functions.
* Also document that name can be null for hdfsCreateSnapshot (that is
counter-intuitive), and that it cannot be null for deleteSnapshot.
* Check that name and path are non-null where it is required and return an
error code rather than segfaulting.
* GetRandomClientID should be returning a 16-byte Class 4 UUID. See
https://github.com/c9n/hadoop/blob/master/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ClientId.java
and
https://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_.28random.29
for more info. Be sure to randomly generate 16 bytes worth of data, then set
the variant and version bits.
* Not specific to this code, but we should be ensuring we're connected when FS
methods are called. We can either transparently connect or complain if we're
not. We should capture this in another Jira.
* New FS methods should check their inputs, especially for empty strings
* Should new hdfs_ext functions set errno if there's a failure?
* Do we need to define hdfsGetCapacity -> libhdfspp_hdfsGetCapacity in wrapper
defs?
Minor point:
* The extra lines for the sub-constructor for the nn_ variable in the
FileSystemImpl ctor should be indented a couple of extra spaces.
> libhdfs++: Implement snapshot operations
> ----------------------------------------
>
> Key: HDFS-10494
> URL: https://issues.apache.org/jira/browse/HDFS-10494
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-10494.HDFS-8707.000.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
