[
https://issues.apache.org/jira/browse/HDFS-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321750#comment-15321750
]
Anu Engineer commented on HDFS-9461:
------------------------------------
Thanks you for the patch. Overall it looks quite good. Some minor comments.
* {{DiskBalancerVolume.java}} can you please rename getFreeCap to getFreeSpace
?
** {{getUsedRatio} why are we multiplying by 1.0 here ? (1.0 * getUsed() /
getCapacity()
* {{ReportCommand.Java}} Apache Lic. header seems to be missing.
** Line 152: Please replace nor with or, or just say node value cannot be empty.
** {{getHelp}} " + "top defaults to 100. E.g.:\n"" do you want to print the
DEFAULT_TOP since it is defined already ?
* {{TestDiskBalancerCommand.java}} missing Apache Lic. header
> DiskBalancer: Add Report Command
> --------------------------------
>
> Key: HDFS-9461
> URL: https://issues.apache.org/jira/browse/HDFS-9461
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 2.8.0
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9461-HDFS-1312.000.patch,
> HDFS-9461-HDFS-1312.001.patch
>
>
> It's quite helpful to do:
> 1) report node information for the top X of DataNodes that will benefit from
> running disk balancer
> 2) report volume level information for any specific DataNode.
> This is done by:
> 1) reading the cluster info, sorting the DiskbalancerNodes by their
> NodeDataDensity and printing out their corresponding information.
> 2) reading the cluster info, and print out volume level information for that
> DataNode requested.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
