[
https://issues.apache.org/jira/browse/HDFS-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012581#comment-13012581
]
Jakob Homan commented on HDFS-1777:
-----------------------------------
bq. Before we go whole-hog on this, can we please make sure to do a little
benchmarking? Java is pretty good at optimizing for repeated strings, so there
may not be much performance to gain here.
+1. Before we get a flood of JIRAs on this (is it really even necessary to
have an umbrella JIRA?), please have some strong numbers to back up the
assertion that string concatenation has a significant negative impact on
performance. This is particularly the case given our experience with
HADOOP-6884.
> HDFS Log improvement Umbrella
> -----------------------------
>
> Key: HDFS-1777
> URL: https://issues.apache.org/jira/browse/HDFS-1777
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, name-node
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
>
> In log messages we used so many '+' operators to construct the message. So
> many string object creations will happen. Instead we can use StringBuilder
> and append all the strings to it.So, we can avoid unncessary String object
> creations.
> So created one Umbrella issue and we can link the all log improvement issues
> to it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
