[ 
https://issues.apache.org/jira/browse/HDFS-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325555#comment-15325555
 ] 

Ming Ma edited comment on HDFS-9016 at 6/11/16 2:35 AM:
--------------------------------------------------------

Thanks all for the input. I will add "-upgradedomain" flag to fsck.

I am still not convinced this is necessary for the reasons explained earlier, 
especially the fact that fsck output could be incompatible when default block 
placement policy changes to any other policy. And that is more likely to happen 
than changing to upgrade domain policy.

Another example is the output of "dfsadmin -report". As we add new attributes 
to DatanodeInfo, the new attributes will be displayed. "dfsadmin -report" 
doesn't use flags to control what attributes get displayed. My main point here 
is we have much bigger surface of backward incompatibility and should take care 
of those scenarios at higher priority.



was (Author: mingma):
Thanks all for the input. I will add "-upgradedomain" flag to fsck.

To make it clear, I am still not convinced this is necessary for the reasons 
explained earlier, specifically the fact that fsck output isn't compatible when 
default block placement policy changes to any other policy. And that is more 
likely to happen than changing only to upgrade domain policy.

Another example is the output of "dfsadmin -report". As we add new attributes 
to DatanodeInfo, the new attributes will be displayed in the output. "dfsadmin 
-report" doesn't use flags to control what attributes get displayed. My main 
point here is we have much bigger surface of backward incompatibility and 
should take care of those scenarios at higher priority.


> Display upgrade domain information in fsck
> ------------------------------------------
>
>                 Key: HDFS-9016
>                 URL: https://issues.apache.org/jira/browse/HDFS-9016
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-9016.patch
>
>
> This will make it easy for people to use fsck to check block placement when 
> upgrade domain is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to