[
https://issues.apache.org/jira/browse/HDFS-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Surendra Singh Lilhore updated HDFS-10505:
------------------------------------------
Attachment: HDFS-10505-002.patch
Thanks [~cmccabe] for review.
bq. I am confused by the changes for setting latestStringId to 1, or
special-casing null in registerStringId.
This is changed because I saw same logic in {{FSImageFormatProtobuf.java}} .
{code}
int getId(E value) {
if (value == null) {
return 0;
}
Integer v = map.get(value);
if (v == null) {
int nv = map.size() + 1;
map.put(value, nv);
return nv;
}
return v;
}
{code}
bq. We also need a test case which has null ACL names, so that this code is
being exercised.
Test code already have ACL entry with null acl name. {{aclEntry(ACCESS, USER,
ALL)}}
I changed the patch based on your suggestion.
Please review..
> OIV's ReverseXML processor should support ACLs
> ----------------------------------------------
>
> Key: HDFS-10505
> URL: https://issues.apache.org/jira/browse/HDFS-10505
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 2.8.0
> Reporter: Colin Patrick McCabe
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-10505-001.patch, HDFS-10505-002.patch
>
>
> OIV's ReverseXML processor should support ACLs. Currently ACLs show up in
> the fsimage.xml file, but we don't reconstruct them with ReverseXML.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
