[
https://issues.apache.org/jira/browse/HDFS-7959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336674#comment-15336674
]
Sangjin Lee commented on HDFS-7959:
-----------------------------------
Thanks [~kihwal] for updating the patch! It looks good to me for the most part.
I only have a couple of minor questions.
{code}
125 String host =
((InetSocketAddress)ctx.channel().remoteAddress()).
126 getAddress().getHostAddress();
127 HttpMethod method = req.method();
{code}
Could this throw an exception (esp. host) in some situations? I think it might
be a good idea to move this into the {{finally}} clause itself and make an
exception here non-fatal. Thoughts?
{code}
140 if (resp == null) {
141 return "000";
142 }
{code}
"000" is not a valid HTTP status code. If the response is null for any reason,
"500" might be as good a choice as any. Also, if we change it to 500, we can
then simply use {{int}} as the return type of {{getResponseCode()}}.
> WebHdfs logging is missing on Datanode
> --------------------------------------
>
> Key: HDFS-7959
> URL: https://issues.apache.org/jira/browse/HDFS-7959
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Critical
> Labels: BB2015-05-TBR
> Attachments: HDFS-7959.1.branch-2.patch, HDFS-7959.1.trunk.patch,
> HDFS-7959.branch-2.patch, HDFS-7959.patch, HDFS-7959.patch, HDFS-7959.patch,
> HDFS-7959.trunk.patch
>
>
> After the conversion to netty, webhdfs requests are not logged on datanodes.
> The existing jetty log only logs the non-webhdfs requests that come through
> the internal proxy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
