[ 
https://issues.apache.org/jira/browse/HDFS-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336827#comment-15336827
 ] 

Bob Hansen commented on HDFS-10515:
-----------------------------------

In:
{code}
    dirList = hdfsListDirectory(fs, listDirTest, &numEntries);
     EXPECT_NONNULL(dirList);
    if (numEntries != 10000) {
         fprintf(stderr, "hdfsListDirectory set numEntries to "
                "%d on directory containing 10000 files.", numEntries);
        return EIO;
     }
     hdfsFreeFileInfo(dirList, numEntries);
{code}
we should free the dirList before returning EIO.  We can put the free up above 
the if(numEntires...) check since we're not looking at the contents, just the 
returned file count.

Can we test privilege failures in TestMkdirs, TestDelete, and TestRename by 
settings privs to 000?



> libhdfs++: Implement mkdirs, rmdir, rename, and remove
> ------------------------------------------------------
>
>                 Key: HDFS-10515
>                 URL: https://issues.apache.org/jira/browse/HDFS-10515
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-10515.HDFS-8707.000.patch, 
> HDFS-10515.HDFS-8707.001.patch, HDFS-10515.HDFS-8707.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to