[ 
https://issues.apache.org/jira/browse/HDFS-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaobing Zhou updated HDFS-10550:
---------------------------------
    Attachment: HDFS-10550-HDFS-1312.000.patch

v000 patch is posted, please kindly review it, thanks.

1. changed -uri to -fs
2. sorted volume list in ReportCommand#handleNodeReport to avoid order 
dependency
3. changed sub tests in TestDiskBalancerCommand#TestReportCommand to various 
unit tests.
4. swapped orders of results checked in TestDiskBalancerCommand#testReportNode.

> DiskBalancer: fix issue of order dependency in iteration in ReportCommand test
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-10550
>                 URL: https://issues.apache.org/jira/browse/HDFS-10550
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HDFS-10550-HDFS-1312.000.patch
>
>
> TestDiskBalancerCommand#testReportNode assumed order of result entries 
> returned, however, DiskBalancerDataNode#volumeSets and 
> DiskBalancerVolumeSet#volumes have no guarantee on the order since they are 
> initialized as HashMap. The test should be fixed by not assuming the order.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to