[
https://issues.apache.org/jira/browse/HDFS-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342490#comment-15342490
]
Anu Engineer commented on HDFS-10553:
-------------------------------------
>From the mail that points out this issue from [~szetszwo]
- There are a few TODOs in the code.
- Tried the help command "hdfs diskbalancer -help plan". There is a typo
"wetolerate" in --thresholdPercentage. Also, we should mention the unit for
--bandwidth.
- We should avoid using the same class name such as DiskBalancer, which is
defined in both the datanode and tools packages. It may be better to call it
DiskBalancerCli for the one in tools.
- I still think that it is better to use weighted mean and weighted variance in
the calculation.
> DiskBalancer: Rename Tools/DiskBalancer class to Tools/DiskBalancerCLI
> ----------------------------------------------------------------------
>
> Key: HDFS-10553
> URL: https://issues.apache.org/jira/browse/HDFS-10553
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: HDFS-1312
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Minor
> Fix For: HDFS-1312
>
>
> Rename the Tools/DiskBalancer, since we have server/DiskBalancer class. This
> is confusing when reading code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
