[
https://issues.apache.org/jira/browse/HDFS-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342598#comment-15342598
]
Lei (Eddy) Xu commented on HDFS-10550:
--------------------------------------
One small issue
{code}
containsString("DISK"),
containsString("/tmp/disk/KmHefYNURo"),
{code}
the {{containsString("DISK")}} is duplicated from the previous line.
+1 pending the fix.
> DiskBalancer: fix issue of order dependency in iteration in ReportCommand test
> ------------------------------------------------------------------------------
>
> Key: HDFS-10550
> URL: https://issues.apache.org/jira/browse/HDFS-10550
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10550-HDFS-1312.000.patch,
> HDFS-10550-HDFS-1312.001.patch
>
>
> TestDiskBalancerCommand#testReportNode assumed order of result entries
> returned, however, DiskBalancerDataNode#volumeSets and
> DiskBalancerVolumeSet#volumes have no guarantee on the order since they are
> initialized as HashMap. The test should be fixed by not assuming the order.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
