[ 
https://issues.apache.org/jira/browse/HDFS-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342691#comment-15342691
 ] 

Anu Engineer commented on HDFS-10552:
-------------------------------------

[~eddyxu] Since this is a completely new file, this change should apply to 
older branches without any conflicts. Can you please try to apply this patch to 
your branch ? if you have not edited the {{TestDiskBalancerCommand.java}} on 
your branch, I do not see where the conflict can come from. You are right we 
certainly want each patch to be focused, but if you patch has 20 lines in 
total, does it matter ? 

On second thought, I see where you are coming from. Have you applied the 
HDFS-10551 patch ? That change can cause a conflict. Makes sense without these 
five lines both these patches will apply on top of each other. 

If that is so, I will revert these fives lines and make both patch work 
together. Sorry I missed that in your earlier subtle comment. I will post patch 
4 soon.



> DiskBalancer "-query" results in NPE if no plan for the node
> ------------------------------------------------------------
>
>                 Key: HDFS-10552
>                 URL: https://issues.apache.org/jira/browse/HDFS-10552
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>    Affects Versions: HDFS-1312
>            Reporter: Lei (Eddy) Xu
>            Assignee: Anu Engineer
>            Priority: Critical
>         Attachments: HDFS-10552-HDFS-1312.001.patch, 
> HDFS-10552-HDFS-1312.002.patch, HDFS-10552-HDFS-1312.003.patch
>
>
> {code}
> 16/06/20 11:50:16 INFO command.Command: Executing "query plan" command.
> java.lang.NullPointerException
>       at 
> org.apache.hadoop.hdfs.protocol.proto.ClientDatanodeProtocolProtos$QueryPlanStatusResponseProto$Builder.setPlanID(ClientDatanodeProtocolProtos.java:12782)
>       at 
> org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolServerSideTranslatorPB.queryDiskBalancerPlan(ClientDatanodeProtocolServerSideTranslatorPB.java:340)
>       at 
> org.apache.hadoop.hdfs.protocol.proto.ClientDatanodeProtocolProtos$ClientDatanodeProtocolService$2.callBlockingMethod(ClientDatanodeProtocolProtos.java:17513)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>       at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1073)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2086)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2082)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:415)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)
>       at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2080)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to