[ 
https://issues.apache.org/jira/browse/HDFS-10342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344366#comment-15344366
 ] 

Kuhu Shukla commented on HDFS-10342:
------------------------------------

Test failures are seen in previous builds as well. I am now trying to find the 
JIRA that may have caused this and will file related test failure JIRAs. 
Failing test {{TestDFSUpgradeWithHA}} passes locally and is not related. 
Requesting [~kihwal], [~daryn] for comments/review. Thanks a lot!

> BlockManager#createLocatedBlocks should not check corrupt replicas if none 
> are corrupt
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-10342
>                 URL: https://issues.apache.org/jira/browse/HDFS-10342
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 2.7.0
>            Reporter: Daryn Sharp
>            Assignee: Kuhu Shukla
>         Attachments: HDFS-10342.001.patch, HDFS-10342.002.patch
>
>
> {{corruptReplicas#isReplicaCorrupt(block, node)}} is called for every node 
> while populating the machines array.  There's no need to invoke the method if 
> {{corruptReplicas#numCorruptReplicas(block)}} returned 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to