[
https://issues.apache.org/jira/browse/HDFS-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351968#comment-15351968
]
Anu Engineer commented on HDFS-10580:
-------------------------------------
[~linyiqun] Thanks for the patch. The original reason that we added print queue
was to debug how the plan is going. But I personally found it very noisy, so
after most of the development was over I removed it from all code path. It is
not that I am against it, for I personally did benefit using the printQueue.
Can you run some tests with larger number of disks (stuff under
TestPlanner.java) and see for yourself if it is too noisy.
Otherwise the patch looks good, and as I said it is really useful for debug
purposes but I would like to you to be the judge of how signal vs. noise for
future developers.
I have too much context to decide if this has any useful info for other
developers.
So run some tests and look at the logs of those tests, and then let me know
what you think.
>From a technical / code point of view, the patch looks good to me.
> DiskBalancer : Make use of unused methods in GreedyPlanner to print debug info
> ------------------------------------------------------------------------------
>
> Key: HDFS-10580
> URL: https://issues.apache.org/jira/browse/HDFS-10580
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-10580.001.patch
>
>
> There are two unused method {{skipVolume}} and {{printQueue}} in class
> {{GreedyPlanner}}. These two methods were added in HDFS-9469 but they are not
> used. In these two method, it will print the detail debug info. So We can
> make use of them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
