[ https://issues.apache.org/jira/browse/HDFS-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014565#comment-13014565 ]
Daryn Sharp commented on HDFS-1751: ----------------------------------- I'd like to please request clarification on code duplication. This usually implies copy-n-paste coding, but that's not the case here. This is a fs limit so the check is highly specific to addChild(...) and the code is very trivial when invoked from that method. I could change the the limit exception to not derive from the base quota exception, but that will cause a ripple of method signature changes and may require the addition of catch blocks up the callers' chains. OTOH, having the limit exceptions derive from a quota exception will make it much easier if/when per-directory limits are added. > Intrinsic limits for HDFS files, directories > -------------------------------------------- > > Key: HDFS-1751 > URL: https://issues.apache.org/jira/browse/HDFS-1751 > Project: Hadoop HDFS > Issue Type: New Feature > Components: data-node > Affects Versions: 0.22.0 > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 0.23.0 > > Attachments: HDFS-1751-2.patch, HDFS-1751-3.patch, HDFS-1751-4.patch, > HDFS-1751.patch > > > Enforce a configurable limit on: > the length of a path component > the number of names in a directory > The intention is to prevent a too-long name or a too-full directory. This is > not about RPC buffers, the length of command lines, etc. There may be good > reasons for those kinds of limits, but that is not the intended scope of this > feature. Consequently, a reasonable implementation might be to extend the > existing quota checker so that it faults the creation of a name that violates > the limits. This strategy of faulting new creation evades the problem of > existing names or directories that violate the limits. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira