[ 
https://issues.apache.org/jira/browse/HDFS-10593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363718#comment-15363718
 ] 

Yuanbo Liu commented on HDFS-10593:
-----------------------------------

[~andrew.wang]Thank you for your response.
You're right, "ipc.maximum.data.length" is used to set maximum RPC message 
size, not PB size. I'm sorry for not investigating clearly. I found a jira 
HDFS-10312 and thought that "ipc.maximum.data.length" was a general property 
for PB size. Turns out Chris did not want to introduce a new property and 
reused "ipc.maximum.data.length" to set PB size when block reporting.
I searched {{setSizeLimit}} in Hadoop project and did not find content about 
fsimage PB serde, so I think we didn't make fsimage serde configurable.

> MAX_DIR_ITEMS should not be hard coded since RPC buff size is configurable 
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-10593
>                 URL: https://issues.apache.org/jira/browse/HDFS-10593
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Yuanbo Liu
>
> In HDFS, "dfs.namenode.fs-limits.max-directory-items" was introduced in 
> HDFS-6102 to restrict max items of single directory, and the value of it can 
> not be larger than the value of MAX_DIR_ITEMS. Since 
> "ipc.maximum.data.length" was added in HADOOP-9676 and documented in 
> HADOOP-13039 to make maximum RPC buffer size configurable, it's not proper to 
> hard code the value of MAX_DIR_ITEMS in {{FSDirectory}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to