[
https://issues.apache.org/jira/browse/HDFS-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368775#comment-15368775
]
Lei (Eddy) Xu commented on HDFS-9809:
-------------------------------------
Hi, [~virajith]
Thanks for great work.
* {{BlockSender#waitForMinLength}}, it is not clear to me that why you need to
change {{RBW}} to {{RIP}} ?
* {{DataStorage#getTrashDirectoryForBlockFile}} we can take this chance to
rename it to {{getTrashDirectoryForBlock}} or {{..ForReplica}}.
* There are many {{UnsupportedOperationException}} in Replica class hierarchy.
It might indicates that these functions are not supposed to be override.
* ASF License for every new file.
* Lets take this chance to use JDK 7 {{try..resource}} in {{breakHardlilnks()}}
?
* {{ReplicaInPipeline#moveReplicaFrom}} it still has a {{File}} parameter.
This is a very large patch, more comments to come ..
> Abstract implementation-specific details from the datanode
> ----------------------------------------------------------
>
> Key: HDFS-9809
> URL: https://issues.apache.org/jira/browse/HDFS-9809
> Project: Hadoop HDFS
> Issue Type: Task
> Components: datanode, fs
> Reporter: Virajith Jalaparti
> Assignee: Virajith Jalaparti
> Attachments: HDFS-9809.001.patch, HDFS-9809.002.patch,
> HDFS-9809.003.patch
>
>
> Multiple parts of the Datanode (FsVolumeSpi, ReplicaInfo, FSVolumeImpl etc.)
> implicitly assume that blocks are stored in java.io.File(s) and that volumes
> are divided into directories. We propose to abstract these details, which
> would help in supporting other storages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
