[
https://issues.apache.org/jira/browse/HDFS-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382519#comment-15382519
]
Daryn Sharp commented on HDFS-10619:
------------------------------------
The common case is {{IIP#getPath}} is called frequently and repeatedly. So
even if it doesn't happen to be called in a few instances, the extra string
overhead (valid concern in general) outweighs the huge reduction in object
allocations for the common case.
Sorry the test broke, that's what I get for separating out a small piece from a
larger patch that has modified that byte[][] to String function. It has much
larger logic problems than the one uncovered here. I'll repost.
> Cache path in InodesInPath
> --------------------------
>
> Key: HDFS-10619
> URL: https://issues.apache.org/jira/browse/HDFS-10619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HDFS-10619.patch
>
>
> INodesInPath#getPath, a frequently called method, dynamically builds the
> path. IIP should cache the path upon construction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
