[ 
https://issues.apache.org/jira/browse/HDFS-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15384858#comment-15384858
 ] 

Xiao Chen commented on HDFS-10225:
----------------------------------

Thanks [~eddyxu] for the new rev.

Nits:
- Any reason not to put the newly added code after the {{locations.isEmpty()}} 
check?
- Javadoc {{@throws}} on parseChangedVolumes needs to be updated.

> DataNode hot swap drives should recognize storage type tags. 
> -------------------------------------------------------------
>
>                 Key: HDFS-10225
>                 URL: https://issues.apache.org/jira/browse/HDFS-10225
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 2.7.2
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HDFS-10225.000.patch, HDFS-10225.001.patch, 
> HDFS-10225.002.patch
>
>
> The current hot swap code only differentiate data dirs by their paths. People 
> might want to change the types of certain data dirs from the default value in 
> an existing cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to