[
https://issues.apache.org/jira/browse/HDFS-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016497#comment-13016497
]
Konstantin Boudnik commented on HDFS-1805:
------------------------------------------
Considering a pretty massive change made in the patch I'd suggest to perhaps
have all initialization/teardowns to be done in appropriate text fixtures (such
as @Before and @After). This way you will be able to eliminate certain code
dups. and make the flow easier to understand/debug.
And perhaps convert the test to Junitv4 while you're at it?
> Some Tests in TestDFSShell can not shutdown the MiniDFSCluster on any
> exception/assertion failure. This will leads to fail other testcases.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1805
> URL: https://issues.apache.org/jira/browse/HDFS-1805
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-1805.patch
>
>
> Some test cases in TestDFSShell are not shutting down the MiniDFSCluster in
> finally.
> If any test assertion failure or exception can result in not shutting down
> this cluster. Because of this other testcases will fail. This will create
> difficulty in finding the actual testcase failures.
> So, better to shutdown the cluster in finally.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
