[
https://issues.apache.org/jira/browse/HDFS-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396547#comment-15396547
]
Jing Zhao commented on HDFS-4176:
---------------------------------
Thanks for addressing the comments, [~eddyxu]
Nit: We can use ThreadFactoryBuilder to simplify the following code. Other than
this the patch looks good to me.
{code}
177 rollEditsRpcExecutor = Executors.newSingleThreadExecutor(
178 new ThreadFactory() {
179 @Override
180 public Thread newThread(Runnable r) {
181 Thread thread =
Executors.defaultThreadFactory().newThread(r);
182 thread.setDaemon(true);
183 return thread;
184 }
185 });
{code}
> EditLogTailer should call rollEdits with a timeout
> --------------------------------------------------
>
> Key: HDFS-4176
> URL: https://issues.apache.org/jira/browse/HDFS-4176
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha, namenode
> Affects Versions: 2.0.2-alpha, 3.0.0-alpha1
> Reporter: Todd Lipcon
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-4176.00.patch, HDFS-4176.01.patch,
> HDFS-4176.02.patch, namenode.jstack4
>
>
> When the EditLogTailer thread calls rollEdits() on the active NN via RPC, it
> currently does so without a timeout. So, if the active NN has frozen (but not
> actually crashed), this call can hang forever. This can then potentially
> prevent the standby from becoming active.
> This may actually considered a side effect of HADOOP-6762 -- if the RPC were
> interruptible, that would also fix the issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
