[
https://issues.apache.org/jira/browse/HDFS-10664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399080#comment-15399080
]
Yuanbo Liu edited comment on HDFS-10664 at 7/29/16 10:02 AM:
-------------------------------------------------------------
[~cnauroth]/[~arpitagarwal] I've prepared v1 patch for this issue, if it's
convenient for you, please help me review it.
I find that this issue is difficult to reproduce by unit test, because of these
two reason:
1. layoutversion is not a configurable property in hadoop
2. there are some kinds of version check existing in different places, and it
will bring a lot of code change if we want to use test case to cover this issue.
So I just compare the create time of VERSION files in my test case to prove
that this patch works. And also I commit my patch to
Hadoop-2.6.3(layoutversion=-60) and upgrade it to
Hadoop-2.7.2(layoutversion=-63) in three nodes. This is what I get from
journalnode data directory:
{code}
[hdfs@bdavm959 current]$ cat VERSION |grep layoutVersion
layoutVersion=-63
[hdfs@bdavm959 current]$ pwd
/home/hdfs/hadoop-data/jn/mycluster/current
{code}
Hope to get your thoughts, Thanks for your time!
was (Author: yuanbo):
[~cnauroth][~arpitagarwal] I've prepared v1 patch for this issue, if it's
convenient for you, please help me review it.
I find that this issue is difficult to reproduce by unit test, because of these
two reason:
1. layoutversion is not a configurable property in hadoop
2. there are some kinds of version check existing in different places, and it
will bring a lot of code change if we want to use test case to cover this issue.
So I just compare the create time of VERSION files in my test case to prove
that this patch works. And also I commit my patch to
Hadoop-2.6.3(layoutversion=-60) and upgrade it to
Hadoop-2.7.2(layoutversion=-63) in three nodes. This is what I get from
journalnode data directory:
{code}
[hdfs@bdavm959 current]$ cat VERSION |grep layoutVersion
layoutVersion=-63
[hdfs@bdavm959 current]$ pwd
/home/hdfs/hadoop-data/jn/mycluster/current
{code}
Hope to get your thoughts, Thanks for your time!
> layoutVersion mismatch between Namenode VERSION file and Journalnode VERSION
> file after cluster upgrade
> -------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10664
> URL: https://issues.apache.org/jira/browse/HDFS-10664
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha, hdfs
> Affects Versions: 2.7.1
> Reporter: Amit Anand
> Assignee: Yuanbo Liu
>
> After a cluster is upgraded I see a mismatch in {{layoutVersion}} between NN
> VERSION file and JN VERSION file.
> Here is what I see:
> Before cluster upgrade:
> ==================
> {code}
> ## Version file from NN current directory
> namespaceID=109645726
> clusterID=CID-edcb62c5-bc1f-49f5-addb-37827340b5de
> cTime=0
> storageType=NAME_NODE
> blockpoolID=BP-786201894-10.0.100.11-1466026941507
> layoutVersion=-60
> {code}
> {code}
> ## Version file from JN current directory
> namespaceID=109645726
> clusterID=CID-edcb62c5-bc1f-49f5-addb-37827340b5de
> cTime=0
> storageType=JOURNAL_NODE
> layoutVersion=-60
> {code}
> After cluster upgrade:
> =================
> {code}
> ## Version file from NN current directory
> namespaceID=109645726
> clusterID=CID-edcb62c5-bc1f-49f5-addb-37827340b5de
> cTime=0
> storageType=NAME_NODE
> blockpoolID=BP-786201894-10.0.100.11-1466026941507
> layoutVersion=-63
> {code}
> {code}
> ## Version file from JN current directory
> namespaceID=109645726
> clusterID=CID-edcb62c5-bc1f-49f5-addb-37827340b5de
> cTime=0
> storageType=JOURNAL_NODE
> layoutVersion=-60
> {code}
> Since {{Namenode}} is what creates {{Journalnode}} {{VERSION}} file during
> {{initializeSharedEdits}}, it should also update the file with correct
> information after the cluster is upgraded and {{hdfs dfsadmin
> -finalizeUpgrade}} has been executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
