[ 
https://issues.apache.org/jira/browse/HDFS-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-9353:
--------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.8.0
           Status: Resolved  (was: Patch Available)

+1 committed trunk through branch-2.8. Thank you for the contribution [~boky01].

> Code and comment mismatch in  JavaKeyStoreProvider 
> ---------------------------------------------------
>
>                 Key: HDFS-9353
>                 URL: https://issues.apache.org/jira/browse/HDFS-9353
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: nijel
>            Assignee: Andras Bokor
>            Priority: Trivial
>             Fix For: 2.8.0
>
>         Attachments: HDFS-9353.01.patch
>
>
> In
> org.apache.hadoop.crypto.key.JavaKeyStoreProvider.JavaKeyStoreProvider(URI 
> uri, Configuration conf) throws IOException
> The comment mentioned is
> {code}
> // Get the password file from the conf, if not present from the user's
> // environment var
> {code}
> But the code takes the value form ENV first
> I think this make sense since the user can pass the ENV for a particular run.
> My suggestion is to change the comment



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to