[
https://issues.apache.org/jira/browse/HDFS-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017780#comment-13017780
]
Aaron T. Myers commented on HDFS-1630:
--------------------------------------
Code looks solid to me as well.
One nit: In the case of a checksum mismatch, could you please add the expected
and actual checksums which didn't match to the error message?
Also, in two places you check for "{{if (checksum != null)}}". Why would
{{checksum}} ever be null?
> Checksum fsedits
> ----------------
>
> Key: HDFS-1630
> URL: https://issues.apache.org/jira/browse/HDFS-1630
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Attachments: editsChecksum.patch, editsChecksum1.patch
>
>
> HDFS-903 calculates a MD5 checksum to a saved image, so that we could verify
> the integrity of the image at the loading time.
> The other half of the story is how to verify fsedits. Similarly we could use
> the checksum approach. But since a fsedit file is growing constantly, a
> checksum per file does not work. I am thinking to add a checksum per
> transaction. Is it doable or too expensive?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
