[ https://issues.apache.org/jira/browse/HDFS-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417472#comment-15417472 ]
James Clampffer commented on HDFS-10740: ---------------------------------------- bq. Actually, I don't think this code in fact needs synchronization because this whole recursion is running in a single thread and futures.push_back is never executed simultaneously. It basically generates a large number of requests sequentially one-by-one, and then just goes to wait on all of the responses. Please let me know if you agree. Yep, you're right. Thanks for clearing that up for me. Everything looks good now that default permissions work; looks like that's why I couldn't get it working during my review yesterday. +1. I'll leave this out in case anyone else wants to review but assuming CI passes I'll commit later tonight or early tomorrow. > libhdfs++: Implement recursive directory generator > -------------------------------------------------- > > Key: HDFS-10740 > URL: https://issues.apache.org/jira/browse/HDFS-10740 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Anatoli Shein > Assignee: Anatoli Shein > Attachments: HDFS-10740.HDFS-8707.000.patch, > HDFS-10740.HDFS-8707.001.patch, HDFS-10740.HDFS-8707.002.patch > > > This tool will allow us do benchmarking/testing our find functionality, and > will be a good example showing how to call a large number or namenode > operations reqursively. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org