[
https://issues.apache.org/jira/browse/HDFS-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418219#comment-15418219
]
Lei (Eddy) Xu commented on HDFS-10636:
--------------------------------------
Hi, [~virajith]
Thanks for working on this. A few questions.
* In {{FsDatasetImpl#fetchReplication}} , please remove the usage {{LOG.info}}.
* In {{ReplicaInfo.java}}. The following comments seem irrelevant to the code
below.
{code}
/** directory where block & meta files belong. */
{code}
Also please do not remove the comments for the constroctors.
* {{breakHardlinksIfNeeded}}, {{ copyMetadata}} and {{copyBlockdata}} should
not be in {{ReplicaInfo}}. Or should not use {{File}} as input.
* {{ReplicaUnderRecovery}}. Is there a way to avoid casting {{ReplicaInfo}} to
{{LocalReplica}}?
* In general, there are places in this patch that return {{ReplicaInfo}} for
{{FinalizedReplica}}. which would makes type system weaker and is not
future-proof. Is it necessary to be changed?
Thanks.
> Modify ReplicaInfo to remove the assumption that replica metadata and data
> are stored in java.io.File.
> ------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10636
> URL: https://issues.apache.org/jira/browse/HDFS-10636
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, fs
> Reporter: Virajith Jalaparti
> Assignee: Virajith Jalaparti
> Attachments: HDFS-10636.001.patch, HDFS-10636.002.patch,
> HDFS-10636.003.patch, HDFS-10636.004.patch, HDFS-10636.005.patch
>
>
> Replace java.io.File related APIs from {{ReplicaInfo}}, and enable the
> definition of new {{ReplicaInfo}} sub-classes whose metadata and data can be
> present on external storages (HDFS-9806).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
