[
https://issues.apache.org/jira/browse/HDFS-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421730#comment-15421730
]
Anu Engineer commented on HDFS-10514:
-------------------------------------
[~xiaobingo] Thanks for the patch. Some minor comments.
# Don't we need to populate the workMap with the right entries for the
{{DiskBalancer#queryWorkStatus}} to read it back. I am wondering if we should
populate these new entries in {{DiskBalancer#createWorkPlan}}. I was not able
to understand where we are populating the values for the new entries in the
DiskBalancerWorkStatus class.
# Can you please modify a test to assert that these values are indeed populated
in this class.
> Augment QueryDiskBalancerPlan to return storage id/type of source/dest volumes
> ------------------------------------------------------------------------------
>
> Key: HDFS-10514
> URL: https://issues.apache.org/jira/browse/HDFS-10514
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-10514-HDFS-1312.000.patch,
> HDFS-10514-HDFS-1312.001.patch
>
>
> DiskBalancerWorkEntry returned by QueryDiskBalancerPlan only contains paths
> of source/dest volumes. It's preferable to get storage id/storage type too.
> Scan command could show a rich set of information how data is moved between
> different volumes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
