[
https://issues.apache.org/jira/browse/HDFS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423103#comment-15423103
]
Jing Zhao commented on HDFS-10764:
----------------------------------
The patch looks good to me. +1 pending Jenkins.
> Fix INodeFile#getBlocks to not return null
> ------------------------------------------
>
> Key: HDFS-10764
> URL: https://issues.apache.org/jira/browse/HDFS-10764
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-10764.01.patch
>
>
> Not all callers of INodeFile#getBlocks check for null. e.g.
> {code}
> public final QuotaCounts storagespaceConsumedContiguous(
> BlockStoragePolicy bsp) {
> ...
> // Collect all distinct blocks
> Set<BlockInfo> allBlocks = new HashSet<>(Arrays.asList(getBlocks()));
> {code}
> We can either fix each caller or alternatively fix getBlocks to never return
> null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
