[
https://issues.apache.org/jira/browse/HDFS-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425237#comment-15425237
]
Arpit Agarwal commented on HDFS-10682:
--------------------------------------
Hi [~vagarychen], thanks for the branch-2 patch. Couple of comments on the
branch-2 v4 patch:
# Missing changes to FsVolumeImpl.java which still synchronizes on the dataset
object.
# BlockSender also needs to be fixed. It looks like we missed this occurrence
in trunk so I'll file a separate Jira to fix it for trunk.
{code}
synchronized(datanode.data) {
replica = getReplica(block, datanode);
replicaVisibleLength = replica.getVisibleLength();
}
{code}
> Replace FsDatasetImpl object lock with a separate lock object
> -------------------------------------------------------------
>
> Key: HDFS-10682
> URL: https://issues.apache.org/jira/browse/HDFS-10682
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Chen Liang
> Assignee: Chen Liang
> Fix For: 3.0.0-alpha2
>
> Attachments: HDFS-10682-branch-2.001.patch,
> HDFS-10682-branch-2.002.patch, HDFS-10682-branch-2.003.patch,
> HDFS-10682-branch-2.004.patch, HDFS-10682.001.patch, HDFS-10682.002.patch,
> HDFS-10682.003.patch, HDFS-10682.004.patch, HDFS-10682.005.patch,
> HDFS-10682.006.patch, HDFS-10682.007.patch, HDFS-10682.008.patch,
> HDFS-10682.009.patch, HDFS-10682.010.patch
>
>
> This Jira proposes to replace the FsDatasetImpl object lock with a separate
> lock object. Doing so will make it easier to measure lock statistics like
> lock held time and warn about potential lock contention due to slow disk
> operations.
> Right now we can use org.apache.hadoop.util.AutoCloseableLock. In the future
> we can also consider replacing the lock with a read-write lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
