[
https://issues.apache.org/jira/browse/HDFS-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Foley updated HDFS-1808:
-----------------------------
Attachment: TestBalancer.java.patch
Replace the three infinite waits with 20-second timeouts. Throw
TimeoutException WITH useful information as to current state. Now if it errs
in the future, at least we'll be able to see why.
Replace the exact expected value with a bounded range (which can be set to
"exact" if you really want that).
Corrected a large number of comments that were out of date and incorrect.
Test now passes Hudson automated testing in connection with HDFS-1295, where it
previously failed.
Posted here for information, but I'm going to subordinate this bug to HDFS-1295
(which it was blocking) and submit a single patch to that Jira.
> TestBalancer waits forever, errs without giving information
> -----------------------------------------------------------
>
> Key: HDFS-1808
> URL: https://issues.apache.org/jira/browse/HDFS-1808
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node, name-node
> Affects Versions: 0.22.0
> Reporter: Matt Foley
> Assignee: Matt Foley
> Attachments: TestBalancer.java.patch
>
>
> In three locations in the code, TestBalancer waits forever on a condition.
> Failures result in Hudson/Jenkins "Timeout occurred" error message with no
> information about where or why. Need to replace with TimeoutExceptions that
> throw a stack trace and useful info about the failure mode.
> In waitForHeartBeat(), it is waiting on an exact match for a value that may
> be coarsely quantized -- i.e., significant deviation from the exact
> "expected" result may occur. Replace with an allowed range of result.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira