[ 
https://issues.apache.org/jira/browse/HDFS-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Foley updated HDFS-1827:
-----------------------------

    Attachment: TestBlockReplacement.java.patch

Replaced the infinite waits with a 20-second timeout. Throw TimeoutException 
WITH useful information as to current state. Now if it errs in the future, at 
least we'll be able to see why.

Also found what appears to be an argument reversal in the assert in line 180.  
My best reading of the meaning of the args, the surrounding comments, and the 
intent of the caller, says that it should be changed.  If I'm correct, this 
would explain the failure.

Finally, added more comments for clarity, and replaced a spurious Boolean with 
boolean.

Posted here for information, but I'm going to subordinate this bug to HDFS-1295 
(which it was blocking) and submit a single patch to that Jira.


> TestBlockReplacement waits forever, errs without giving information
> -------------------------------------------------------------------
>
>                 Key: HDFS-1827
>                 URL: https://issues.apache.org/jira/browse/HDFS-1827
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>             Fix For: 0.23.0
>
>         Attachments: TestBlockReplacement.java.patch
>
>
> In method checkBlocks(), TestBalancer waits forever on a condition. Failures 
> result in Hudson/Jenkins "Timeout occurred" error message with no information 
> about where or why. Need to replace with TimeoutException that throws a stack 
> trace and useful info about the failure mode.
> Also investigate possible cause of failure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to