[
https://issues.apache.org/jira/browse/HDFS-10793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437718#comment-15437718
]
Andrew Wang commented on HDFS-10793:
------------------------------------
Overall looks great to me, thanks for picking this up Manoj. One little nit,
could we undo some of the whitespace changes? I think your IDE is configured to
align parameters, but I think our normal convention is to double indent. I also
would mildly prefer if you generate the patch without "--no-prefix", since then
I can apply with just "git apply hdfs.patch".
[~arpitagarwal] / [~liuml07] either of you want to review too? Should be a
quick one.
> Fix HdfsAuditLogger binary incompatibility introduced by HDFS-9184
> ------------------------------------------------------------------
>
> Key: HDFS-10793
> URL: https://issues.apache.org/jira/browse/HDFS-10793
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Andrew Wang
> Assignee: Manoj Govindassamy
> Priority: Blocker
> Attachments: HDFS-10793.001.patch
>
>
> HDFS-9184 added a new parameter to an existing method signature in
> HdfsAuditLogger, which is a Public/Evolving class. This breaks binary
> compatibility with implementing subclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
