[ 
https://issues.apache.org/jira/browse/HDFS-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439295#comment-15439295
 ] 

Zhe Zhang commented on HDFS-10798:
----------------------------------

Thanks [~xkrogen] for the work. Path LGTM overall. One nit:
# {{dfs.namenode.write-lock.reporting.threshold.ms}} better to be 
{{dfs.namenode.write-lock-reporting-threshold-ms}}. I don't think we have 
formally documented the convention of naming config keys. But intuitively, 
{{.}} indicates a hierarchy.
# Could you also verify the reported test failures?

+1 pending the above.

> Make the threshold of reporting FSNamesystem lock contention configurable
> -------------------------------------------------------------------------
>
>                 Key: HDFS-10798
>                 URL: https://issues.apache.org/jira/browse/HDFS-10798
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: logging, namenode
>            Reporter: Zhe Zhang
>            Assignee: Erik Krogen
>              Labels: newbie
>         Attachments: HDFS-10789.001.patch
>
>
> Currently {{FSNamesystem#WRITELOCK_REPORTING_THRESHOLD}} is set at 1 second. 
> In a busy system a lower overhead might be desired. In other scenarios, more 
> aggressive reporting might be desired. We should make the threshold 
> configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to