[ https://issues.apache.org/jira/browse/HDFS-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445139#comment-15445139 ]
Hadoop QA commented on HDFS-10804: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color} | {color:red} HDFS-10804 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | HDFS-10804 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12825966/HDFS-10804-002.patch | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/16559/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Use finer-granularity lock for ReplicaMap > ----------------------------------------- > > Key: HDFS-10804 > URL: https://issues.apache.org/jira/browse/HDFS-10804 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Affects Versions: 3.0.0-beta1 > Reporter: Fenghua Hu > Assignee: Fenghua Hu > Priority: Minor > Fix For: 3.0.0-beta1 > > Attachments: HDFS-10804-002.patch > > > In currently implementation, ReplicaMap takes an external object as lock for > synchronization. > In function FsDatasetImpl#FsDatasetImpl(), the object is for synchronization > is "this", i.e. FsDatasetImpl: > volumeMap = new ReplicaMap(this); > and in private FsDatasetImpl#addVolume(), "this" object is used for > synchronization as well. > ReplicaMap tempVolumeMap = new ReplicaMap(this); > I am not sure if we really need so big object FsDatasetImpl for ReplicaMap's > synchronization. If it's not necessary, this could reduce lock contention on > FsDatasetImpl object and improve performance. > Could you please give me some suggestions? Thanks a lot! > Fenghua -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org