[
https://issues.apache.org/jira/browse/HDFS-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447388#comment-15447388
]
Lei (Eddy) Xu edited comment on HDFS-10808 at 8/29/16 11:25 PM:
----------------------------------------------------------------
[~anu] Thanks for the explanations.
* Is {{clearExitFlag()}} duplicated to {{setRunnable()}}?
* bq. Also we seem to have introduced some unintended side effects like some
lines becoming no-op.
I don't follow why it becomes no-ops. If someone else have set exitFlag, either
way (using {{continue}} or {{break}}) here will stop the while loop, right?
{code}
if (!shouldRun()) {
continue;
}
{code}
My understanding was that this is to check whether *_the other thread_* set
this flag to stop {{DiskBalancer}}.
* If you put a {{clearExitFlag()}} in the for loop:
{code}
for (Map.Entry<VolumePair, DiskBalancerWorkItem> entry :
workMap.entrySet()) {
blockMover.clearExitFlag();
blockMover.copyBlocks(entry.getKey(), entry.getValue());
}
{code}
then {{diskbalancer -cancel}} command can not actually stop {{BlockMover}}
thread for multiple work items?
was (Author: eddyxu):
[~anu] Thanks for the explanations.
* Is {{clearExitFlag()}} duplicated to {{setRunnable()}}?
* bq. Also we seem to have introduced some unintended side effects like some
lines becoming no-op.
I don't follow why it becomes no-ops. If someone else have set exitFlag, either
way (using {{continue}} or {{break}}) here will stop the while loop, right?
{code}
if (!shouldRun()) {
continue;
}
{code}
* If you put a {{clearExitFlag()}} in the for loop:
{code}
for (Map.Entry<VolumePair, DiskBalancerWorkItem> entry :
workMap.entrySet()) {
blockMover.clearExitFlag();
blockMover.copyBlocks(entry.getKey(), entry.getValue());
}
{code}
then {{diskbalancer -cancel}} command can not actually stop {{BlockMover}}
thread for multiple work items?
> DiskBalancer does not execute multi-steps plan-redux
> ----------------------------------------------------
>
> Key: HDFS-10808
> URL: https://issues.apache.org/jira/browse/HDFS-10808
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-10808.001.patch
>
>
> This is to redo of the fix in HDFS-10598
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
