[
https://issues.apache.org/jira/browse/HDFS-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019102#comment-13019102
]
Jitendra Nath Pandey commented on HDFS-1824:
--------------------------------------------
If the 'fs' is not an instance of DistributedFileSystem the current code prints
an error and returns with an exit code. The patch changes to throw
IllegalArgumentException. I believe DFSAdmin#run will catch this exception and
still print just the error. Does it make sense to add/modify a unit test to
make sure an error code is returned in case of this error?
Patch looks good otherwise.
> delay instantiation of file system object until it is needed (linked to
> HADOOP-7207)
> ------------------------------------------------------------------------------------
>
> Key: HDFS-1824
> URL: https://issues.apache.org/jira/browse/HDFS-1824
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HDFS-1824.patch
>
>
> also re-factor the code little bit to avoid checking for instance of DFS in
> multiple places.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
