[
https://issues.apache.org/jira/browse/HDFS-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDFS-10820:
-----------------------------
Attachment: HDFS-10820.002.patch
Good catch, thanks [~xiaochen] for the quick review! Attach a new patch for
addressing your comment.
> DataStreamer#Responder close fails lead the error recovery
> ----------------------------------------------------------
>
> Key: HDFS-10820
> URL: https://issues.apache.org/jira/browse/HDFS-10820
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-10820.001.patch, HDFS-10820.002.patch
>
>
> When worked for HDFS-6532, I found that the error recovery will happens when
> responder close fails. The related codes:
> {code}
> {code:title=DataStreamer.java|borderStyle=solid}
> public void run() {
> long lastPacket = Time.monotonicNow();
> TraceScope scope = null;
> while (!streamerClosed && dfsClient.clientRunning) {
> // if the Responder encountered an error, shutdown Responder
> if (errorState.hasError() && response != null) {
> try {
> response.close();
> response.join();
> response = null;
> } catch (InterruptedException e) {
> // If interruptedException happens, the response will not be set to
> null
> // and that will lead the error recovry.
> LOG.warn("Caught exception", e);
> }
> }
> // Here need add a finally block to set response as null
> ...
> {code}
> Can see the related
> comment:https://issues.apache.org/jira/browse/HDFS-6532?focusedCommentId=15448770&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15448770
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
