[ https://issues.apache.org/jira/browse/HDFS-10820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15451307#comment-15451307 ]
Xiao Chen edited comment on HDFS-10820 at 8/31/16 6:23 AM: ----------------------------------------------------------- +1, will commit after 24 hours. (I edited the title to be more specific, feel free to let me know if you want it otherwise) was (Author: xiaochen): +1, will commit after 24 hours. > Reuse closeResponder to reset the response variable in DataStreamer#run > ----------------------------------------------------------------------- > > Key: HDFS-10820 > URL: https://issues.apache.org/jira/browse/HDFS-10820 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Minor > Attachments: HDFS-10820.001.patch, HDFS-10820.002.patch > > > When worked for HDFS-6532, I found that the error recovery will happens when > responder close fails. The related codes: > {code} > {code:title=DataStreamer.java|borderStyle=solid} > public void run() { > long lastPacket = Time.monotonicNow(); > TraceScope scope = null; > while (!streamerClosed && dfsClient.clientRunning) { > // if the Responder encountered an error, shutdown Responder > if (errorState.hasError() && response != null) { > try { > response.close(); > response.join(); > response = null; > } catch (InterruptedException e) { > // If interruptedException happens, the response will not be set to > null > // and that will lead the error recovry. > LOG.warn("Caught exception", e); > } > } > // Here need add a finally block to set response as null > ... > {code} > Can see the related > comment:https://issues.apache.org/jira/browse/HDFS-6532?focusedCommentId=15448770&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15448770 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org