[ 
https://issues.apache.org/jira/browse/HDFS-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15460388#comment-15460388
 ] 

Xiao Chen commented on HDFS-10835:
----------------------------------

Thanks [~jzhuge] for working on this, and [~aw] for commenting.

To explain Allen's comment, the typo seems to be introduced by HADOOP-12249, 
which is 3.0 only.
Suggest to update versions accordingly.

- please also update the comment to be consistent on {{HttpFS}}
- you probably already know this: kms.sh is pretty much the same. Have we 
considered abstract the helper function somehow?

> Typo in httpfs.sh hadoop_usage
> ------------------------------
>
>                 Key: HDFS-10835
>                 URL: https://issues.apache.org/jira/browse/HDFS-10835
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: httpfs
>    Affects Versions: 3.0.0-alpha1
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Trivial
>         Attachments: HDFS-10835.001.patch, HDFS-10835.002.patch
>
>
> Typo in method {{hadoop_usage}} of {{httpfs.sh}}. The {{kms}} words should be 
> replaced with {{httpfs}}:
> {noformat}
> function hadoop_usage
> {
>   hadoop_add_subcommand "run" "Start kms in the current window"
>   hadoop_add_subcommand "run -security" "Start in the current window with 
> security manager"
>   hadoop_add_subcommand "start" "Start kms in a separate window"
>   hadoop_add_subcommand "start -security" "Start in a separate window with 
> security manager"
>   hadoop_add_subcommand "status" "Return the LSB compliant status"
>   hadoop_add_subcommand "stop" "Stop kms, waiting up to 5 seconds for the 
> process to end"
>   hadoop_add_subcommand "top n" "Stop kms, waiting up to n seconds for the 
> process to end"
>   hadoop_add_subcommand "stop -force" "Stop kms, wait up to 5 seconds and 
> then use kill -KILL if still running"
>   hadoop_add_subcommand "stop n -force" "Stop kms, wait up to n seconds and 
> then use kill -KILL if still running"
>   hadoop_generate_usage "${MYNAME}" false
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to