[
https://issues.apache.org/jira/browse/HDFS-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468041#comment-15468041
]
Xiao Chen commented on HDFS-10841:
----------------------------------
Thanks Kihwal for taking care of this!
The original problem only shows up in branch-2, because {{src}} is not used at
all. Looking at this patch, I think it makes more sense to use {{path}} for
logging and remove {{src}}. +1 pending jenkins.
> Remove duplicate or unused variable in appendFile()
> ---------------------------------------------------
>
> Key: HDFS-10841
> URL: https://issues.apache.org/jira/browse/HDFS-10841
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Minor
> Attachments: HDFS-10841.patch
>
>
> A new findbugs warning was reported (See HDFS-10745). branch-2.8 might have
> the same problem.
> {noformat}
> Code Warning
> DLS Dead store to src in
> org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp
> .appendFile(FSNamesystem, String, FSPermissionChecker, String, String,
> boolean, boolean)
> Bug type DLS_DEAD_LOCAL_STORE (click for details)
> In class org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp
> In method org.apache.hadoop.hdfs.server.namenode.FSDirAppendOp
> .appendFile(FSNamesystem, String, FSPermissionChecker, String, String,
> boolean, boolean)
> Local variable named src
> At FSDirAppendOp.java:[line 92]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
