[
https://issues.apache.org/jira/browse/HDFS-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated HDFS-10742:
---------------------------------
Attachment: HDFS-10742.016.patch
v016:
* Avoid a race condition recording the last-logged timestamp.
* Set suppression interval to be
[configurable|https://issues.apache.org/jira/browse/HDFS-10713?focusedCommentId=15452881&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15452881]
with a default of 10s
v016 doesn't set the 300ms interval to be configurable, neither does it
separate the log from FsDatasetImpl.
bq. As you said its syntactic sugar. If this approach feels that inelegant I am
okay with eliminating AutoCloseableLock.
*shrug* I've stated my case against it, but if you're not convinced and prefer
to retain it: no big deal.
> Measurement of lock held time in FsDatasetImpl
> ----------------------------------------------
>
> Key: HDFS-10742
> URL: https://issues.apache.org/jira/browse/HDFS-10742
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.0.0-alpha2
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-10742.001.patch, HDFS-10742.002.patch,
> HDFS-10742.003.patch, HDFS-10742.004.patch, HDFS-10742.005.patch,
> HDFS-10742.006.patch, HDFS-10742.007.patch, HDFS-10742.008.patch,
> HDFS-10742.009.patch, HDFS-10742.010.patch, HDFS-10742.011.patch,
> HDFS-10742.012.patch, HDFS-10742.013.patch, HDFS-10742.014.patch,
> HDFS-10742.015.patch, HDFS-10742.016.patch
>
>
> This JIRA proposes to measure the time the of lock of {{FsDatasetImpl}} is
> held by a thread. Doing so will allow us to measure lock statistics.
> This can be done by extending the {{AutoCloseableLock}} lock object in
> {{FsDatasetImpl}}. In the future we can also consider replacing the lock with
> a read-write lock.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
