[
https://issues.apache.org/jira/browse/HDFS-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475005#comment-15475005
]
Anu Engineer edited comment on HDFS-10553 at 9/8/16 9:05 PM:
-------------------------------------------------------------
[~manojg] The changes look good. There is one more place where we have to
change. Diskbalancer is invoked via a script called hdfs that is located at
{{hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs}}
it is a bash script and the HADOOP_CLASSNAME variable should change too. We
should replace this line
{code}
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DiskBalancer
{code}
with
{code}
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DiskBalancerCLI
{code}
Our current set of tests will not catch this, may be you can address this issue
also as part of addressing HDFS-10599. Right now to verify I suggest that you
deploy a pseudo node and make sure that you can run {{hdfs diskbalancer}} and
you are able to see help.
was (Author: anu):
[~manojg] The changes look good. There is one more place where we have to
change. Diskbalancer is invoked via a script called hdfs that is located at
{{hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs}}
it is bash script and the HADOOP_CLASSNAME variable should change too. We
should replace this line
{code}
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DiskBalancer
{code}
with
{code}
HADOOP_CLASSNAME=org.apache.hadoop.hdfs.tools.DiskBalancerCLI
{code}
Our current set of tests will not catch this, may be you can address this issue
also as part of addressing HDFS-10599. Right now to verify I suggest that you
deploy a pseudo node deployment and make sure that you can run {{hdfs
diskbalancer}} and you are able to see help.
> DiskBalancer: Rename Tools/DiskBalancer class to Tools/DiskBalancerCLI
> ----------------------------------------------------------------------
>
> Key: HDFS-10553
> URL: https://issues.apache.org/jira/browse/HDFS-10553
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: balancer & mover
> Affects Versions: 3.0.0-alpha2
> Reporter: Anu Engineer
> Assignee: Manoj Govindassamy
> Priority: Minor
> Attachments: HDFS-10553.001.patch
>
>
> Rename the Tools/DiskBalancer, since we have server/DiskBalancer class. This
> is confusing when reading code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
